Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(cmake/modules): bump rules to falco-rules-2.0.0-rc1 #2775

Merged
merged 3 commits into from
Sep 7, 2023
Merged

update(cmake/modules): bump rules to falco-rules-2.0.0-rc1 #2775

merged 3 commits into from
Sep 7, 2023

Conversation

leogr
Copy link
Member

@leogr leogr commented Sep 5, 2023

What type of PR is this?

/kind feature

Special notes for your reviewer:

This is specifically required for Falco 0.36 RC1

/milestone 0.36.0

Does this PR introduce a user-facing change?:

NONE

@poiana poiana added this to the 0.36.0 milestone Sep 5, 2023
@poiana poiana requested review from Andreagit97 and Kaizhe September 5, 2023 15:54
@leogr leogr mentioned this pull request Sep 5, 2023
Closed
@leogr leogr force-pushed the submodule/update-falco-rules branch 2 times, most recently from cbd869a to e2370e1 Compare September 6, 2023 08:28
@leogr
Copy link
Member Author

leogr commented Sep 6, 2023

Rebased, since #2780 got merged.

@leogr leogr changed the title chore: update falco rules update(cmake/modules): bump rules to falco-rules-2.0.0-rc1 Sep 6, 2023
@leogr leogr force-pushed the submodule/update-falco-rules branch from e2370e1 to 3d8b8f3 Compare September 6, 2023 16:23
@leogr leogr mentioned this pull request Sep 6, 2023
Closed
jasondellaluce
jasondellaluce previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Sep 6, 2023
leogr added 3 commits September 7, 2023 11:08
@leogr
fix(ci): make scap file work from within the container
841b8c8 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
chore(submodule): bump testing framework to 76d1743
7305fab 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(cmake/modules): bump rules to falco-rules-2.0.0-rc1
f15560c 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the submodule/update-falco-rules branch from 3d8b8f3 to f15560c Compare September 7, 2023 09:09
@poiana poiana added size/S and removed size/XS labels Sep 7, 2023
FedeDP
FedeDP approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Andreagit97
Andreagit97 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 79b39b5 into master Sep 7, 2023
15 checks passed
@poiana poiana deleted the submodule/update-falco-rules branch September 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@FedeDP FedeDP FedeDP approved these changes

@jasondellaluce jasondellaluce jasondellaluce left review comments

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes kind/feature lgtm release-note-none size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
5 participants
@leogr @poiana @FedeDP @jasondellaluce @Andreagit97